Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delay to nap present()s #4

Open
gunar opened this issue Mar 5, 2016 · 4 comments
Open

Add delay to nap present()s #4

gunar opened this issue Mar 5, 2016 · 4 comments

Comments

@gunar
Copy link
Member

gunar commented Mar 5, 2016

I believe a small delay for nap present() would be great for the developer to understand what's going on.

How important this is? I'm not sure.

Simply using setTimeout has shown to produce a lot of problems with nap. I believe we should buffer all present() and process sequentially. If we do this, we could even stop in time right before nap's present(). Imagine how cool it would be to be able to change the code and see what nap will do, before actually updating the store.

@weepy
Copy link

weepy commented Mar 14, 2016

But isn't it possible for the resultant action of nap-a to change which nap runs next ?
You could have a simple option that would break the automatic execution of a nap. Then a dev tool could provide a button to run it.

@gunar
Copy link
Member Author

gunar commented Mar 14, 2016

Great idea! I just created #8 for that. Let's leave this one for discussion on the delay (should it be implemented anyway).

Here, I've pictured the DevTools executing a sequence of naps with 500ms intervals. This seems important for chained/consecutive naps. Question being: How important/who often do we have these?

@weepy
Copy link

weepy commented Mar 14, 2016

Difficult to know without a real world example ?
On Mon, 14 Mar 2016 at 12:13, Gunar C. Gessner [email protected]
wrote:

Great idea! I just created #8
#8 for that. Let's leave
this one for discussion on the delay (should it be implemented anyway).

Here, I've pictured the DevTools executing a sequence of naps with 500ms
intervals. This seems important for chained/consecutive naps. Question
being: How important/who often do we have these?


Reply to this email directly or view it on GitHub
#4 (comment).

@gunar
Copy link
Member Author

gunar commented Mar 14, 2016

Precisely. Let's come back to this in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants