Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Node v8 in aws lambda #27

Open
inian opened this issue Apr 15, 2018 · 2 comments
Open

Add support for Node v8 in aws lambda #27

inian opened this issue Apr 15, 2018 · 2 comments

Comments

@inian
Copy link

inian commented Apr 15, 2018

Changing the environment to node v8 and deploying doesn't work.

@tomardern
Copy link

I recommend that the Docs are changed to state that this package only currently works for Node 6.10

@cirdes
Copy link

cirdes commented Jul 30, 2018

as mentioned on #25 to run on 8.10 we just have to update the nodejs on .babelrc("8.10") and on serverless.yml (nodejs8.10) and change the handler to:

exports.handler = async (event) => {
  let result;
  let browser;
  try {
    browser = await setup.getBrowser();
    result = await exports.run(browser);
  } catch (err) {
        console.log(err);
        return err;
  }
  return result;
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants