Requests arguments

[mngmntt]

Hi Sam,

what do you think about passing requests parameters through slumber such as timeout, proxies, stream, etc. At this moment the only way is to overwrite slumber's _request method.

I will create PR if you support this decision.

Cheers,
Alex

[samgiles]

Good idea. I shall do this!

Thanks for the suggestion

[jhermann]

For most / all things you mentioned, you can also pass in your own session, especially if they're not really per-request (like timeouts which most often are fixed per application / API use).

[IAlwaysBeCoding]

@jhermann I think it should be a simple fix of adding kwargs to the API class to set values such as timeouts,stream,proxy,even user-agent to the requests.Session instance stored in self._store .

[daisylb]

FWIW, timeouts can't actually be set in a Session; I think they used to be in earlier versions of Requests but not anymore, and they won't be added (see kennethreitz/requests#2011). So, currently, adding a default timeout looks like this:

class TimeoutHTTPAdapter(HTTPAdapter):
    def __init__(self, timeout=None, *args, **kwargs):
        self.timeout = timeout
        super().__init__(*args, **kwargs)

    def send(self, *args, **kwargs):
        kwargs['timeout'] = self.timeout
        return super().send(*args, **kwargs)

_session = Session()
_session.mount("http://", TimeoutHTTPAdapter(timeout=3))

Which is quite a lot of boilerplate for what I think is probably a pretty common requirement.