Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slumber 0.5.1 returns empty string on successful POST #46

Open
dekoza opened this issue Dec 8, 2012 · 7 comments
Open

slumber 0.5.1 returns empty string on successful POST #46

dekoza opened this issue Dec 8, 2012 · 7 comments

Comments

@dekoza
Copy link

dekoza commented Dec 8, 2012

After successful POST slumber 0.5.1 (most recent in pypi) returns empty string instead of dict representation of newly created object.

This is a regression from 0.4.2

http://stackoverflow.com/questions/13777823/slumber-returns-empty-string-instead-of-object-data/

@stringfellow
Copy link

bump. This breaks packages built on top (such as tastypie-queryset-client) and is related to #50.

@merwok
Copy link
Contributor

merwok commented Mar 7, 2013

I propose this as desired behavior: if the response has a body with a content-type slumber can deserialize, parse and return it, else if there is a location header, return it, otherwise return None.

@dstufft
Copy link
Collaborator

dstufft commented Mar 7, 2013

That behavior sounds sane to me.

@dekoza
Copy link
Author

dekoza commented May 17, 2013

Bump. This is still present in 0.6.0 and breaks packages built on top. Behavior proposed by merwok sounds OK.

@merwok
Copy link
Contributor

merwok commented May 17, 2013

I’m available to review a patch/PR.

@stringfellow
Copy link

Any news :-))) ?

@merwok
Copy link
Contributor

merwok commented Jul 31, 2013

Patch welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants