Replace manual Cosign with GitHub Attestations #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works pretty good, except that I can't use
cosignto verify the containers anymore. There's a bit of a dance where you need to manually download the manifest for the tag, then get the actual "artifact" by its digest (and save that json bundle), and then do a pretty longcosign verify-blob-attestation ...command.See: actions/attest-build-provenance#162 (comment)
Still, this provenance info is nice,
gh attestation verify oci://ghcr.io/samhclark/custom-silverblue:40 --repo samhclark/custom-silverblueworks. And I'm not doing verified ostree registry things yet anyway. Got a month or so until I'm gonna rebase onto Fedora 41, so I'll have time to figure out the best way to get a verified registry.Maybe that's adding back Cosign, and doing two signing steps. Maybe with a key instead of keyless. Maybe there's some other way. But the provenance info seems worth keeping.