From 279910d602ffb70c6ab96747814635c3228b2893 Mon Sep 17 00:00:00 2001 From: Djones4822 Date: Thu, 14 Apr 2022 13:10:03 -0400 Subject: [PATCH 1/3] fix: incorrect path to config.xml in browser version --- src/browser/AppVersionProxy.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/browser/AppVersionProxy.js b/src/browser/AppVersionProxy.js index 81b565a..77c5987 100644 --- a/src/browser/AppVersionProxy.js +++ b/src/browser/AppVersionProxy.js @@ -27,7 +27,7 @@ function readConfig(success, fail) { xhr.addEventListener("error", function () { fail(e); }); - xhr.open("get", "../config.xml", true); + xhr.open("get", "config.xml", true); xhr.send(); } else { From 612026c87715f82689807531049a886d180f7e7c Mon Sep 17 00:00:00 2001 From: Djones4822 Date: Thu, 14 Apr 2022 13:20:31 -0400 Subject: [PATCH 2/3] add missing error parameter to xhr error handling --- src/browser/AppVersionProxy.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/browser/AppVersionProxy.js b/src/browser/AppVersionProxy.js index 77c5987..990c896 100644 --- a/src/browser/AppVersionProxy.js +++ b/src/browser/AppVersionProxy.js @@ -24,7 +24,7 @@ function readConfig(success, fail) { } }); - xhr.addEventListener("error", function () { + xhr.addEventListener("error", function (e) { fail(e); }); xhr.open("get", "config.xml", true); From c5d14dcc4a39a4e0c08f30d2b3d6f044db66a026 Mon Sep 17 00:00:00 2001 From: Djones4822 Date: Thu, 14 Apr 2022 13:20:38 -0400 Subject: [PATCH 3/3] 0.1.14 --- CHANGELOG.md | 5 +++++ VERSION | 2 +- package.json | 2 +- plugin.xml | 2 +- 4 files changed, 8 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a1e6c98..14fb32d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,8 @@ +### 0.1.14 + +* Fixed browser platform check for config.xml [Issue#128](https://github.com/sampart/cordova-plugin-app-version/issues/128) +* Fix browser platform xhr error handling missing parameter [Issue#118](https://github.com/sampart/cordova-plugin-app-version/issues/118) + ### 0.1.13 * [iOS: getAppName to return localized value (like Android)](https://github.com/sampart/cordova-plugin-app-version/pull/127) diff --git a/VERSION b/VERSION index 7ac4e5e..71d6a66 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -0.1.13 +0.1.14 diff --git a/package.json b/package.json index 158b486..95663d9 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "cordova-plugin-app-version", - "version": "0.1.13", + "version": "0.1.14", "description": "Cordova plugin to return the version number of the current app", "scripts": { "test": "echo \"Error: no test specified\" && exit 1" diff --git a/plugin.xml b/plugin.xml index de74102..4665f55 100644 --- a/plugin.xml +++ b/plugin.xml @@ -2,7 +2,7 @@ + version="0.1.14"> AppVersion