Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce --options coming last in CLI #238

Open
2 tasks
samualtnorman opened this issue Jan 30, 2025 · 0 comments · May be fixed by #246
Open
2 tasks

Enforce --options coming last in CLI #238

samualtnorman opened this issue Jan 30, 2025 · 0 comments · May be fixed by #246

Comments

@samualtnorman
Copy link
Owner

samualtnorman commented Jan 30, 2025

Enforce that options (.e.g. --watch) must come last in our CLI.

Currently you can do stuff like hsm --watch push. This is ambiguous because it makes it look like you're trying to do hsm --watch=push. Although we don't accept option values not joined to the option name via =, other command applications do. Our users may mistake hsm for a command that does. We would then misinterpret that argument that was intended for an option as either a command or a command argument which could cause unexpected behaviour.

  • Deprecate it starting 0.22
  • Enforce it starting 0.23
SarahIsWeird added a commit to SarahIsWeird/hackmud-script-manager that referenced this issue Feb 3, 2025
@SarahIsWeird SarahIsWeird linked a pull request Feb 3, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant