Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localisation #40

Open
8 of 11 tasks
samuelthomas2774 opened this issue Dec 19, 2022 · 4 comments
Open
8 of 11 tasks

Localisation #40

samuelthomas2774 opened this issue Dec 19, 2022 · 4 comments
Labels
enhancement New feature or request localisation

Comments

@samuelthomas2774
Copy link
Owner

samuelthomas2774 commented Dec 19, 2022

  • Electron app support
    • Relative times
  • Discord activity support
    • Splatoon 3
  • Add translation authors to app about panel
  • Fix language detection
  • Fix setting language in all windows

@TotorRuns
Copy link

Translator for German and English

@samuelthomas2774
Copy link
Owner Author

samuelthomas2774 commented Jan 28, 2023

I've added translation support for most of the Electron app. (I think there's still a few things that need adding, and I'm also adding (partial) support for Discord activities.)

Translation strings are stored in src/app/i18n/locale. Adding a new language should just be making a copy of en-gb.ts, editing it, adding it to src/app/i18n/index.ts and running Rollup.

Language detection doesn't work properly yet. app.i18n.changeLanguage('...') can be used in the main process to change the language in the main process and any open windows (but not any new windows, i18next also accepts cimode here which just shows the translation keys).

(cc. @TotorRuns)

@samuelthomas2774
Copy link
Owner Author

@Inkception @hilot06

I've added some extra keys for things I missed: https://github.com/samuelthomas2774/nxapi/compare/b9b9f6a8d74d1ba24ef8b84fc502d04985e64ed7..f8ab3721714849a77b9feb056aa291bbacd91019#diff-6439e40dd9e95cc1adf4effe25ea70a75c5a52dc0e04d831b9416f1a50da8d54. Could you add these please, then I'll merge both pull requests.

Thank you again, and sorry it's taken a while for me to review these.

@Inkception
Copy link
Contributor

On my way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request localisation
Development

No branches or pull requests

3 participants