-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Un - provisioning an application #10
Comments
Good idea |
Line 273: def xmlrpc_unprovision(self,app_id,environment):
|
I was going to add the ability to have an app provisioned for sandbox and production, hence the environment parameter which is currently ignored |
Be warned that this may affect notifications that are currently in transmission. It will likely be a very small amount and a corner case but could still cancel some notifications, depending on your load. |
Good point. Will amend as necessary. |
This is the reason I didn't support it originally. If you want to ensure delivery, you can keep a copy of all the transmissions' deferreds in an instance variable on the server class. When each one completes or fails, clean up. When un-provisioning, spin until all deferreds in that list are cleaned up, or time them out. |
If multiple requests for provisioning an appID are ignored, we shouldn't we add a method for killing a provision - to allow for updating PEM files without restarting the server?
The text was updated successfully, but these errors were encountered: