Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid raising error when DB update fails? #110

Open
cjcolvar opened this issue Aug 29, 2022 · 0 comments
Open

Avoid raising error when DB update fails? #110

cjcolvar opened this issue Aug 29, 2022 · 0 comments

Comments

@cjcolvar
Copy link
Member

We're running into a problem in Avalon where the persisting fails due to DB column size issues which blocks even loading the encode record in the rails console making debugging hard. I wonder if we should take this comment seriously and not raise an error and stop the execution flow when persisting during the callback fails. We'll have to explore if there are any adverse effects if we don't raise an error and how we might surface the issue in a different way.

model.update(encode_attributes) # Don't fail if persisting doesn't succeed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant