Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove farm*.staticflickr.com URLs #27

Closed
tacman opened this issue Jun 3, 2024 · 3 comments
Closed

Remove farm*.staticflickr.com URLs #27

tacman opened this issue Jun 3, 2024 · 3 comments

Comments

@tacman
Copy link
Contributor

tacman commented Jun 3, 2024

https://www.flickr.com/services/api/misc.urls.html

The urls are now at live., farms have been deprecated.

It seems, though, that this should be in the flickr library (and tests) rather than here, though maybe both.

In this case, tests fail because it's trying to download a file from the farm url.

vendor/bin/phpunit 
PHPUnit 8.5.38 by Sebastian Bergmann and contributors.

  Warning - The configuration file did not pass validation!
  The following problems have been detected:

  Line 7:
  - Element 'testsuite': The attribute 'name' is required but missing.

  Test results may not be as expected.


E                                                                   1 / 1 (100%)

Time: 263 ms, Memory: 6.00 MB

There was 1 error:

1) Samwilson\PhpFlickrCli\Test\TemplateTest::testCreation
copy(): php_network_getaddresses: getaddrinfo for farmf.staticflickr.com failed: Name or service not known

/home/tac/g/tacman/phpflickr-cli/src/Template.php:153
/home/tac/g/tacman/phpflickr-cli/tests/TemplateTest.php:77

ERRORS!
Tests: 1, Assertions: 0, Errors: 1.

@samwilson
Copy link
Owner

Yes, I totally agree: this app shouldn't have to know about the URLs at all, it should just get them from PhpFlickr.

Where are you seeing the farm URLs here?

@tacman
Copy link
Contributor Author

tacman commented Jun 4, 2024

in Samwilson\PhpFlickrCli\Test\TemplateTest::testCreation triggers the error, but it seems like indeed the call is in phpFlickr.

Regardless, both the tests and library should change, since that format is no longer valid.

@samwilson samwilson changed the title remove farm urls Remove farm*.staticflickr.com URLs Jun 13, 2024
@samwilson
Copy link
Owner

I've opened samwilson/phpflickr#70 to track this. No changes need to be made here I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants