From cbc0971f7a396ba3169c09e4b68ec7bbe445cf4f Mon Sep 17 00:00:00 2001 From: san7890 Date: Fri, 16 Aug 2024 17:18:48 -0600 Subject: [PATCH] brugh --- .github/ISSUE_TEMPLATE/bug_report_form.yml | 4 ++-- interface/interface.dm | 9 ++++++--- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report_form.yml b/.github/ISSUE_TEMPLATE/bug_report_form.yml index 093e7a6d02f45..0c8f7c706bad0 100644 --- a/.github/ISSUE_TEMPLATE/bug_report_form.yml +++ b/.github/ISSUE_TEMPLATE/bug_report_form.yml @@ -11,9 +11,9 @@ body: - type: input id: reporting-version attributes: - label: Reporting Version + label: Client Version description: | - The BYOND version you are using to report this issue. You can find this information in the bottom right corner of the BYOND client. + The BYOND version you are using to report this issue. You can find this information in the bottom left corner of the "About BYOND" window in the BYOND client. placeholder: "515.1642" - type: textarea id: issue-summary diff --git a/interface/interface.dm b/interface/interface.dm index a5110ea02bc38..c414c6f2a2527 100644 --- a/interface/interface.dm +++ b/interface/interface.dm @@ -72,6 +72,9 @@ var/base_link = githuburl + "/issues/new?template=bug_report_form.yml" var/list/concatable = list(base_link) + var/client_version = "[byond_version].[byond_build]" + concatable += ("&reporting-version=" + client_version) + // the way it works is that we use the ID's that are baked into the template YML and replace them with values that we can collect in game. if(GLOB.round_id) concatable += ("&round-id=" + GLOB.round_id) @@ -82,12 +85,12 @@ for(var/entry in GLOB.revdata.testmerge) var/datum/tgs_revision_information/test_merge/tm = entry all_tms += "- \[[tm.title]\]([githuburl]/pull/[tm.number])" - var/all_tms_joined = all_tms.Join("\n") // for some reason this can't go in the [] + var/all_tms_joined = jointext(all_tms, "\n") // for some reason this can't go in the [] concatable += ("&test-merges=" + all_tms_joined) - var/url_params = "Reporting client version: [byond_version].[byond_build]\n\n[local_template]" - DIRECT_OUTPUT(src, link("[githuburl]/issues/new?template=bug_report_form.yml]")) + var/final_link = link(jointext(concatable, "")) + DIRECT_OUTPUT(src, final_link) else to_chat(src, span_danger("The Github URL is not set in the server configuration.")) return