Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Share Cards should work! Right now, they are not working. #139

Open
hhff opened this issue Jan 19, 2022 · 2 comments
Open

All Share Cards should work! Right now, they are not working. #139

hhff opened this issue Jan 19, 2022 · 2 comments
Assignees

Comments

@hhff
Copy link
Member

hhff commented Jan 19, 2022

No description provided.

@limsohee1002 limsohee1002 self-assigned this Jan 19, 2022
@limsohee1002
Copy link
Contributor

@hhff It seems like only the homepage social card is not working. The problem is homepage image is not added in contentful and it is using the default asset which is a static asset. For some reason, Next js is not resolving the asset URL. I suspect the issue is content={defaultUrl}. Maybe because it is not src attribute, it doesn't resolve the URL? I tested with <img src={defaultUrl}/> and that worked fine.

This problem can be easily solved if we add a meta image on contentful. I have a default asset so I can just add it.
Would this be a fine solution or do you want me to dig in deeper so that we can use the static asset?

@hhff
Copy link
Member Author

hhff commented Jan 24, 2022

@limsohee1002 that's a fine solution!

@mokaymokay mokaymokay assigned nahbee10 and unassigned limsohee1002 Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants