Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address designer QA items #36

Merged
merged 7 commits into from
Nov 21, 2024
Merged

Address designer QA items #36

merged 7 commits into from
Nov 21, 2024

Conversation

nahbee10
Copy link

@nahbee10 nahbee10 commented Nov 19, 2024

Description

  • Update type system and color based on the updated design system
  • Mobile Menu Shows no information when accessed from the Submit a request page
  • Submit A Request Form: Placeholder text not disappearing when user clicks in
  • Overflow navigation should open to show the active topic
  • Help button is overlapping with mobile menu
  • Topics Section should switch to two up grid on mobile
  • Left Nav
  • Related Articles Block
  • Submit Request Form
  • Mobile Footer Layout Tweaks
  • update the search dropdown style
  • remove square bg color behind the search bar

Type(s) of changes

  • Bug fix
  • New feature
  • Update to an existing feature

Motivation for PR

How Has This Been Tested?

Tested on local preview
⚠️ how to view the preview:
step 1. login to Uniswap Zendesk using credentials on 1password
step 2. open this link(https://support.uniswap.org/theming/theme/03977d98-78e7-4326-a99a-2f86e214b021) to activate the staging theme(will not affect the production theme)
step 3. open this link(https://support.uniswap.org/hc/en-us) to view the staging site without iframe nest

Applicable screenshots

Follow-up PR

@nahbee10 nahbee10 marked this pull request as draft November 19, 2024 21:31
@nahbee10 nahbee10 changed the title [WIP] Address designer QA items Address designer QA items Nov 20, 2024
@nahbee10 nahbee10 marked this pull request as ready for review November 20, 2024 05:24
@nahbee10 nahbee10 requested a review from mokaymokay November 20, 2024 05:25
Copy link

@mokaymokay mokaymokay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not seeing mobile menu on submit request page:
Screenshot 2024-11-20 at 6 44 53 PM

I tried setting the theme to dark then refreshing but it doesn't seem to persist?

Copy link

@mokaymokay mokaymokay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The theme setting doesn't persist for me.. Does it work for you?

Are breadcrumbs supposed to not wrap, or is this a bug?

Screenshot 2024-11-20 at 9 43 50 PM

Is there supposed to be an active state for when article upvote button state is aria-pressed=true? Right now there isn't one
Screenshot 2024-11-20 at 9 44 51 PM

@nahbee10 nahbee10 merged commit 9dd32c7 into master Nov 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants