Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect Search API to FAQ block on homepage #40

Merged
merged 7 commits into from
Dec 10, 2024
Merged

Conversation

nahbee10
Copy link

@nahbee10 nahbee10 commented Dec 10, 2024

Description

Type(s) of changes

  • Bug fix
  • New feature
  • Update to an existing feature

Motivation for PR

How Has This Been Tested?

Tested on local preview

Applicable screenshots

https://www.loom.com/share/e7e6974b945641d9b79390a959bc47ba?sid=e4f75150-ee31-4504-a49b-a94632f308e6

Follow-up PR

@nahbee10 nahbee10 requested a review from mokaymokay December 10, 2024 14:03
Copy link

@mokaymokay mokaymokay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we store the faq articles like how we store the mobile nav items to prevent API limit? Preview and code looks good otherwise

@nahbee10 nahbee10 requested a review from mokaymokay December 10, 2024 16:33
Copy link

@mokaymokay mokaymokay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is there a way to QA this change on the preview site?

@nahbee10 nahbee10 merged commit 5a623bc into master Dec 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants