Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value of num_params in the disc classes #1102

Open
bartgol opened this issue Dec 23, 2024 · 0 comments
Open

Value of num_params in the disc classes #1102

bartgol opened this issue Dec 23, 2024 · 0 comments

Comments

@bartgol
Copy link
Collaborator

bartgol commented Dec 23, 2024

I think we should store num_params in more fine-grain detail in the disc classes. Right now, the disc factory stores this as the sum scalar+distributed. However, this value is later used by the disc classes as the domain dim of dxdp. While this is in principle correct, we never do this for distributed params. That is, we never store a multivector with distributed domain (we can't!).

So I wonder if we should make the disc classes

  • store two values: num_scalar_params and num_dist_params?
  • store num_params as the number of scalar params?
  • something else?

@mperego you may have an opinion on this, or perhaps correct a flaw in my understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant