You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think we should store num_params in more fine-grain detail in the disc classes. Right now, the disc factory stores this as the sum scalar+distributed. However, this value is later used by the disc classes as the domain dim of dxdp. While this is in principle correct, we never do this for distributed params. That is, we never store a multivector with distributed domain (we can't!).
So I wonder if we should make the disc classes
store two values: num_scalar_params and num_dist_params?
store num_params as the number of scalar params?
something else?
@mperego you may have an opinion on this, or perhaps correct a flaw in my understanding.
The text was updated successfully, but these errors were encountered:
I think we should store num_params in more fine-grain detail in the disc classes. Right now, the disc factory stores this as the sum scalar+distributed. However, this value is later used by the disc classes as the domain dim of
dxdp
. While this is in principle correct, we never do this for distributed params. That is, we never store a multivector with distributed domain (we can't!).So I wonder if we should make the disc classes
num_scalar_params
andnum_dist_params
?num_params
as the number of scalar params?@mperego you may have an opinion on this, or perhaps correct a flaw in my understanding.
The text was updated successfully, but these errors were encountered: