Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Create ShellScript subclass #42

Open
jmgate opened this issue Jul 3, 2024 · 0 comments
Open

BREAKING: Create ShellScript subclass #42

jmgate opened this issue Jul 3, 2024 · 0 comments
Assignees
Labels
Type: Refactor Refactoring existing code to improve long-term sustainability.

Comments

@jmgate
Copy link
Collaborator

jmgate commented Jul 3, 2024

Create a ShellScript subclass of StagedScript and move all the run() and commands_executed functionality, etc., into the subclass. This way, users who have no desire to interact with the underlying shell have no need to worry about any of that. It also sets us up for a future in which we develop a more powerful Shell class to augment the functionality provided by subprocess (along the lines of shell-logger).

Note: This will be a breaking change, as existing users will need to inherit from a different class.

@jmgate jmgate added the Type: Refactor Refactoring existing code to improve long-term sustainability. label Jul 3, 2024
@jmgate jmgate self-assigned this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Refactor Refactoring existing code to improve long-term sustainability.
Projects
None yet
Development

No branches or pull requests

1 participant