Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Stage class #43

Open
jmgate opened this issue Jul 3, 2024 · 0 comments
Open

Create a Stage class #43

jmgate opened this issue Jul 3, 2024 · 0 comments
Assignees
Labels
Type: Refactor Refactoring existing code to improve long-term sustainability.

Comments

@jmgate
Copy link
Collaborator

jmgate commented Jul 3, 2024

Given the way the conceptual stage is implemented in the code, it'd be real nice to have a Stage class, with methods defined for the different phases, that users could inherit from in creating their own stages. We didn't do things this way initially, because we wanted the ease of a user to be able to simply apply the @stage() decorator to a method, and have StagedScript handle all the rest of the magic behind the scenes. That said, it might be possible to preserve backward compatibility and have a decorator dynamically create a Stage derivative behind the scenes. I don't know. I get the feeling this would clean some things up—especially for power users—but at the expense of a higher barrier to entry for newbies.

Note: Depending on how this is implemented, it'll likely be a breaking change.

@jmgate jmgate added the Type: Refactor Refactoring existing code to improve long-term sustainability. label Jul 3, 2024
@jmgate jmgate self-assigned this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Refactor Refactoring existing code to improve long-term sustainability.
Projects
None yet
Development

No branches or pull requests

1 participant