You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 18, 2020. It is now read-only.
In some occasions it might be worth performance wise to not write classic getters like Response::get_body() and return that to PHP using RETURN_STRING but to write a return function Response::return_body(zval* return_value) instead. In this case this would save passing around a std::string (or additional changes to enable return by reference / smart_ptr). This is a little bit ugly though so smart_ptrs might actually be a better solution. One way or another we should find a good solution for this and use it constantly throughout the codebase.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In some occasions it might be worth performance wise to not write classic getters like
Response::get_body()
and return that to PHP usingRETURN_STRING
but to write a return functionResponse::return_body(zval* return_value)
instead. In this case this would save passing around a std::string (or additional changes to enable return by reference / smart_ptr). This is a little bit ugly though so smart_ptrs might actually be a better solution. One way or another we should find a good solution for this and use it constantly throughout the codebase.The text was updated successfully, but these errors were encountered: