Skip to content
This repository has been archived by the owner on Jun 18, 2020. It is now read-only.

[ZendEngine Driver] Efficient returning of variables #54

Open
martin-schilling opened this issue Jan 23, 2018 · 0 comments
Open

[ZendEngine Driver] Efficient returning of variables #54

martin-schilling opened this issue Jan 23, 2018 · 0 comments

Comments

@martin-schilling
Copy link
Collaborator

In some occasions it might be worth performance wise to not write classic getters like Response::get_body() and return that to PHP using RETURN_STRING but to write a return function Response::return_body(zval* return_value) instead. In this case this would save passing around a std::string (or additional changes to enable return by reference / smart_ptr). This is a little bit ugly though so smart_ptrs might actually be a better solution. One way or another we should find a good solution for this and use it constantly throughout the codebase.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant