Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add x-scheme-handler/* branch to account #2

Open
PRESFIL opened this issue Jun 6, 2021 · 11 comments · May be fixed by #8
Open

[Feature] Add x-scheme-handler/* branch to account #2

PRESFIL opened this issue Jun 6, 2021 · 11 comments · May be fixed by #8

Comments

@PRESFIL
Copy link

PRESFIL commented Jun 6, 2021

x-scheme-handler/* branch is used to set the default browser for the * protocol, but it cannot be edited from selectdefaultapplication. It would be nice to have such an opportunity.

It might even be better to display all the branches and types encountered.

@magnus-ISU
Copy link

Interesting. This is a trivial change, though it seems that Qt reports anything with x-scheme-handler as invalid even if it seems like it should be fine. Running my fork with the -V option we get tons of

In file  "Signal"  mimetype  "x-scheme-handler/sgnl"  is invalid. Ignoring...

I could add in a hardcoded exception for x-scheme-handler/* to be considered valid overriding what Qt claims. Guess I'll make a different pull request for that which can be accepted after my current changes.

@magnus-ISU
Copy link

Hmm maybe won't be as easy as I hoped

image

There's no icon file associated with these, and there also seems to be some bugs regarding re-parsing them into QMimeTypes and back

@PRESFIL
Copy link
Author

PRESFIL commented Dec 30, 2021

I said *, actually the question was specifically about x-scheme-handler/http and
x-scheme-handler/http. I just thought that it would be nice to implement this whole
tree since it is missing.

Running my fork with the -V option we get tons of
In file "Signal" mimetype "x-scheme-handler/sgnl" is invalid. Ignoring..

What about x-scheme-handler/http? xdg-mime works with it correctly:

xdg-mime query default x-scheme-handler/https
firefox.desktop

grep 'x-scheme-handler/http' /usr/share/applications/mimeinfo.cache

@magnus-ISU
Copy link

I've figured out all the problems and the feature is now implemented in my fork. Just got to wait for it to get upstreamed

@PRESFIL
Copy link
Author

PRESFIL commented Dec 31, 2021

Oh thank you! Looking at the @sandsmark activity since November, it won't be soon.

@magnus-ISU
Copy link

Yeah lol, but you can compile and install it yourself without too much trouble. If you're on arch let me know and I can send you a PKGBUILD, but otherwise it shouldn't be too difficult to package for yourself (or even easier to just drop in /usr/local/bin)

@PRESFIL
Copy link
Author

PRESFIL commented Jan 1, 2022

Yes, I'm on an Arch-based distribution.

@PRESFIL
Copy link
Author

PRESFIL commented Jan 2, 2022

All right, thank you. You have seriously reworked the layout... "Small changes"

@magnus-ISU
Copy link

=D

@magnus-ISU
Copy link

magnus-ISU commented Jan 2, 2022

If there's anything you think should be different, let me know. The only problem the new layout might introduce I think is that it doesn't behave well if the window size is small (is there a good way to make a responsive layout in Qt?). But the added information makes it worth it I think. Do you disagree with any decisions I made?

EDIT: also I pushed a small change a moment ago that makes it so that it behaves better when it has less space to work with, so rerun makepkg -fsi to try it out if that is your concern

EDIT: and again more big changes, this time fixing one of the major differences which I had accidentally removed each mimetype's description

@magnus-ISU magnus-ISU linked a pull request Jan 3, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants