Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Research] Figure out how to migrate the API to a snekomatic-style shared-maintenance lib #31

Open
webknjaz opened this issue Dec 2, 2019 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@webknjaz
Copy link
Member

webknjaz commented Dec 2, 2019

Nathaniel Smith has designed quite a beautiful API for representing GH App/Installation entities back in August. I'd like octomachinery to reuse them partially and maybe offload some parts to a third-party lib based on that.

The idea is to have a separate lib that would be octomachinery's dependency so that:

  • we'd have a shared code maintenance
  • the API's UX/DX would be great
  • it'd partially help avoid asyncio lock-in allowing it do be used in a broader variety of envs

For this, octomachinery needs some refactoring that I've started already. Also, we need to figure out what would belong to that library and what would have to stay inside of octomachinery.

Ref: https://github.com/python-trio/snekomatic/blob/13e233c/snekomatic/gh.py

Fund with Polar
@webknjaz webknjaz added enhancement New feature or request help wanted Extra attention is needed question Further information is requested labels Dec 2, 2019
@webknjaz
Copy link
Member Author

@ekohl ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant