Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CRITICAL] Installation objects in API now have also app_slug key #32

Open
webknjaz opened this issue Jan 11, 2020 · 2 comments
Open

[CRITICAL] Installation objects in API now have also app_slug key #32

webknjaz opened this issue Jan 11, 2020 · 2 comments
Assignees
@webknjaz
Labels
bug Something isn't working

Comments

@webknjaz
Copy link
Member

webknjaz commented Jan 11, 2020 •
edited by polar-sh bot
Loading

Example: 'app_slug': 'chronographer-staging'.
It creates the same problem as #21 before.

We need to migrate away from using dataclasses for API structs in favor of something more flexible or find a way to loosely map JSON to dataclasses.

Fund with Polar
@webknjaz webknjaz added the bug Something isn't working label Jan 11, 2020
@webknjaz webknjaz self-assigned this Jan 11, 2020
webknjaz added a commit that referenced this issue Jan 11, 2020
@webknjaz
🐛 Add new app_slug key to installation struct
7627596 
Partially addresses #32
@webknjaz webknjaz mentioned this issue Aug 5, 2020
Closed
@devlounge
Copy link

Any update on this?

@webknjaz
Copy link
Member Author

Well, it works for now. The complete refactoring would need more effort than I have time for currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@webknjaz webknjaz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@webknjaz @devlounge