Refactor gui #113
Merged
Refactor gui #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_software_config)
…r, and not export this, for do this, not set run arg(storage_secret)
Closed
|
目前这个GUI的文件结构更改看起来不错。感觉GUI架构的主要缺点是没有对象化各个配置项，纯列表操作导致扩展性和理解性较差，后面可以看看修改下对象化各个配置项以支持解析与导出（可以先改一个配置项然后review一下效果 |
sanmusen214
reviewed
Sep 10, 2024
There was a problem hiding this comment.
storage_secret参数应该不能删，你删了能跑起来吗
There was a problem hiding this comment.
在网上搜索了一段这个字段的功能，发现他是需要调用nicegui的持久化存储使用的，并没有发现在项目中使用nicegui的存储功能，本项目也不存储比较安全系数较高的账号密码、密钥等信息，所以觉得并不需要此参数来加密浏览器会话 cookie, 并且本项目的加密字段是写死在json文件里的，安全性并不高
故删除，测试了一下不影响现有的项目运作
There was a problem hiding this comment.
使用命令行启动GUI时如果指定了token字段是会使用到storage_secret的，启动时没有给定会报错。python jsoneditor.py --token happytree
|
中场休息，森哥检视一下, 模块化正在弄，先拆每个json文件的，最后拆每个json文件里面每一个小项的，必须要先提交一波了，要不然搞不清楚自己到底在写啥，需要commit摆正自己正在干的事 |
Closed
|
因为有部分功能排在了此PR之后不能，再拖了😌菜的安详，麻烦森哥看一眼吧帮忙排一下版之类的，nicegui太难写了 |
|
最近有点忙，等几天哈 |
|
已合并，我测几天 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when I want to test the first module, gui, is diffcult, so I want to refactor it first, do you like it? first submit a check for you, give me some advise if you dont like this behavior
#103