Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom dimensions #105

Open
yotov opened this issue Jun 16, 2020 · 3 comments
Open

Custom dimensions #105

yotov opened this issue Jun 16, 2020 · 3 comments

Comments

@yotov
Copy link

yotov commented Jun 16, 2020

Hello guys, I did some research and find this lib as a useful replacement for bootstrap grid when I do a react project with styled-components.

I found that I could change the default configuration and this helped me a lot, but it would be greater if I could extend available dimensions with some extra breakpoints ( for example xxl: 1560 and hd: 1920 ).

Do you have any plans to allow such customization?

@santosfrancisco
Copy link
Owner

@yotov Thank you so much for using this lib! Your suggestion for custom breakpoints is incredible, but it is a little difficult to implement. I just suggest adding two more breakpoints and you can define those sizes. what about this? Or if you have any idea how to implement this, a PR is welcome.

@yotov
Copy link
Author

yotov commented Jun 17, 2020

If you could add two new breakpoints it would be good for now.

I saw the code and I know that the perfect solution is more difficult. I will try to create a PR :)

@DanielTamkin
Copy link

Any progress on that PR @yotov? Might take a stab at it sometime in August. Would be great to have custom breakpoints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants