Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support TextUnit for SymbolLayer.textVariableAnchorOffset #151

Open
sargunv opened this issue Dec 20, 2024 · 5 comments
Open

Support TextUnit for SymbolLayer.textVariableAnchorOffset #151

sargunv opened this issue Dec 20, 2024 · 5 comments
Labels
enhancement New feature or change to an existing feature upstream This issue can't be resolved until an upstream issue is resolved

Comments

@sargunv
Copy link
Owner

sargunv commented Dec 20, 2024

  1. it doesn't work at all, blocked by SymbolLayer.textVariableAnchorOffset can't be set to any value but nil() #143
  2. once it works, it needs to support expressions for array elements, blocked by Design Proposal: Allow creating arrays with expressions maplibre/maplibre-style-spec#950
@sargunv sargunv added enhancement New feature or change to an existing feature upstream This issue can't be resolved until an upstream issue is resolved labels Dec 20, 2024
@westnordost
Copy link
Collaborator

Should the property be disabled (read: commented out) until the upstream issue is resolved?

@sargunv
Copy link
Owner Author

sargunv commented Dec 21, 2024

Until the first issue is resolved, yeah that's reasonable

@westnordost
Copy link
Collaborator

Oh, I though the whole thing would be blocked by an upstream issue, not only step two.

@sargunv
Copy link
Owner Author

sargunv commented Dec 22, 2024

The property can't be set at all without the first issue. The property can't support TextUnit in SP without the second issue.

@sargunv
Copy link
Owner Author

sargunv commented Dec 22, 2024 •
edited
Loading

Tracking PR in the JS style spec for the second issue: maplibre/maplibre-style-spec#951

I haven't set up a MLN dev env locally to work on that side yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or change to an existing feature upstream This issue can't be resolved until an upstream issue is resolved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sargunv @westnordost