Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mythicdungeons memory leak #64

Open
kingakis2 opened this issue Oct 23, 2024 · 6 comments
Open

mythicdungeons memory leak #64

kingakis2 opened this issue Oct 23, 2024 · 6 comments
Labels
resolution: fixed type: bug Something isn't working

Comments

@kingakis2
Copy link

hello, it looks like that chunk spawner limiter causes a minimal memory leak with mythicdungeons when it load and unloads world dungeons instances

it would be cool and option like excluded worlds but where you could tell the plugin to only work on these world because, dungeons can have different world numbers instances or that the issue be fixed

image
https://git.mythiccraft.io/mythiccraft/MythicDungeons/-/issues/444

mythicdungeons have section of memory leaks for devs, idk if it can be useful here https://git.mythiccraft.io/mythiccraft/MythicDungeons/-/wikis/Memory-Leaks

@sarhatabaot
Copy link
Owner

sarhatabaot commented Oct 26, 2024

Hi! CSL already has an excluded worlds feature! Just check the config. :)
I've just changed that feature to allow you to include or exclude worlds.

@sarhatabaot
Copy link
Owner

I'm not entirely sure where the memory leak is happening, do you mind sending me the heapdump so I can prevent this?
If you don;t want to send it here, you can message me on discord: sarhatabaot

@kingakis2
Copy link
Author

hello, i will upload the heapdump again and i know that excluded world exist but, it would be cool an option to make the plugin ONLY works on certain worlds because, mythicdungeons can have different numbers instances of dungeons with different names so, i must add so many excluded worlds if i use it

@kingakis2
Copy link
Author

kingakis2 commented Oct 26, 2024

(i deleted it) here is

@sarhatabaot
Copy link
Owner

hello, i will upload the heapdump again and i know that excluded world exist but, it would be cool an option to make the plugin ONLY works on certain worlds because, mythicdungeons can have different numbers instances of dungeons with different names so, i must add so many excluded worlds if i use it

As I mentioned before. I have just added this feature and it will be in future releases.
Thank you for the dump :)

@sarhatabaot
Copy link
Owner

This issue may be fixed in the latest release. I'm leaving this issue open in-case it wasn't actually fixed.

@sarhatabaot sarhatabaot added type: bug Something isn't working resolution: fixed labels Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution: fixed type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants