Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SessionManager to make it more testable #490

Open
krishna-acondy opened this issue Jul 23, 2021 · 0 comments
Open

Refactor SessionManager to make it more testable #490

krishna-acondy opened this issue Jul 23, 2021 · 0 comments

Comments

@krishna-acondy
Copy link
Contributor

We can move the polling logic from the SessionManager into a separate function like we did in the SasViyaApiClient. This will make it easier to unit test while mocking server responses etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@krishna-acondy