Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking Change: Update useComputeApi param #563

Open
saadjutt01 opened this issue Sep 28, 2021 · 0 comments
Open

Breaking Change: Update useComputeApi param #563

saadjutt01 opened this issue Sep 28, 2021 · 0 comments
Labels
breaking change refactoring Restructuring existing code

Comments

@saadjutt01
Copy link
Member

Current approach:

useComputeApi - Only relevant when the serverType is SASVIYA. If true the Compute API is used. If false the JES API is used. If null or undefined the Web approach is used.
useComputeApi: boolean | null = null

Proposal:

To update param useComputeApi and it's usage, have it as an optional enum

enum ComputeApi {
  Compute = 'Compute',
  Jes = 'Jes',
  Web = 'Web'
}
@allanbowe allanbowe added refactoring Restructuring existing code breaking change and removed refactoring Restructuring existing code labels Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change refactoring Restructuring existing code
Projects
None yet
Development

No branches or pull requests

2 participants