You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Install the SAS extension base on the latest Main branch. Switch to a profile with connection type 'SAS9.4(local-COM)',try to run some code, it will show Cancel button on 'SAS code running...'. However it does not support Cancel action with SAS9.4(local-COM) connection.
Steps to reproduce
Steps to reproduce the behavior:
Create a new SAS profile with connection type SAS9.4(local-COM) or switch to a profile with connection type SAS9.4(local-COM)
Run some code below
proc print data=sashelp.class;
run;
Expected behavior
No Cancel button on 'SAS code running...', since the feature is not available now.
Screenshots
Environment (please complete the following information):
Client OS: [e.g. Windows 11]
Extension version: [e.g. v1.0.0]
The text was updated successfully, but these errors were encountered:
It's not only against COM but also SSH. #355 added empty cancel implementation to SSH and COM.
It should not.
The idea is to not show cancel button if a session does not support cancel (no such function).
See https://github.com/sassoftware/vscode-sas-extension/blob/main/client/src/commands/run.ts#L141
I heard that @smorrisj will be implementing cancel for COM so will defer to him. If we don't support cancel on SSH, the function should be removed.
smorrisj
changed the title
It can cancel the code running with connection type SAS9.4(local-COM)
Implement Cancel Function for SAS9.4(local-COM)
Jul 18, 2023
Describe the bug
Install the SAS extension base on the latest Main branch. Switch to a profile with connection type 'SAS9.4(local-COM)',try to run some code, it will show Cancel button on 'SAS code running...'. However it does not support Cancel action with SAS9.4(local-COM) connection.
Steps to reproduce
Steps to reproduce the behavior:
proc print data=sashelp.class;
run;
Expected behavior
No Cancel button on 'SAS code running...', since the feature is not available now.
Screenshots
Environment (please complete the following information):
Client OS: [e.g. Windows 11]
Extension version: [e.g. v1.0.0]
The text was updated successfully, but these errors were encountered: