Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Cancel Function for SAS9.4(local-COM) #393

Closed
Zhirong2022 opened this issue Jul 13, 2023 · 2 comments
Closed

Implement Cancel Function for SAS9.4(local-COM) #393

Zhirong2022 opened this issue Jul 13, 2023 · 2 comments
Assignees
Labels
automation Issue has been covered by automation test bug Something isn't working

Comments

@Zhirong2022
Copy link
Collaborator

Describe the bug
Install the SAS extension base on the latest Main branch. Switch to a profile with connection type 'SAS9.4(local-COM)',try to run some code, it will show Cancel button on 'SAS code running...'. However it does not support Cancel action with SAS9.4(local-COM) connection.

Steps to reproduce
Steps to reproduce the behavior:

  1. Create a new SAS profile with connection type SAS9.4(local-COM) or switch to a profile with connection type SAS9.4(local-COM)
  2. Run some code below
    proc print data=sashelp.class;
    run;

Expected behavior
No Cancel button on 'SAS code running...', since the feature is not available now.

Screenshots
image

Environment (please complete the following information):
Client OS: [e.g. Windows 11]
Extension version: [e.g. v1.0.0]

@Zhirong2022 Zhirong2022 added the bug Something isn't working label Jul 13, 2023
@scnwwu
Copy link
Member

scnwwu commented Jul 13, 2023

It's not only against COM but also SSH.
#355 added empty cancel implementation to SSH and COM.
It should not.
The idea is to not show cancel button if a session does not support cancel (no such function).
See https://github.com/sassoftware/vscode-sas-extension/blob/main/client/src/commands/run.ts#L141
I heard that @smorrisj will be implementing cancel for COM so will defer to him. If we don't support cancel on SSH, the function should be removed.

@scnwwu scnwwu assigned smorrisj and unassigned clangsmith and 2TomLi Jul 13, 2023
@smorrisj smorrisj changed the title It can cancel the code running with connection type SAS9.4(local-COM) Implement Cancel Function for SAS9.4(local-COM) Jul 18, 2023
@tianliang657 tianliang657 added the automation Issue has been covered by automation test label Aug 15, 2023
@scnwwu
Copy link
Member

scnwwu commented Jan 30, 2024

Cancel supported for local 94 with #592

@scnwwu scnwwu closed this as completed Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Issue has been covered by automation test bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants