http proxy: make isLocalhost() case insensitive

saucelabs · Nov 20, 2024 · 673bc9c · 673bc9c
1 parent fe67efc
commit 673bc9c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/http_proxy.go b/http_proxy.go
@@ -17,6 +17,7 @@ import (
 	"net/http"
 	"net/url"
 	"slices"
+	"strings"
 	"time"
 
 	"github.com/saucelabs/forwarder/hostsfile"
@@ -176,6 +177,9 @@ func NewHTTPProxy(cfg *HTTPProxyConfig, pr PACResolver, cm *CredentialsMatcher,
 	if err != nil {
 		return nil, fmt.Errorf("read localhost aliases: %w", err)
 	}
+	for i := range lh {
+		lh[i] = strings.ToLower(lh[i])
+	}
 	hp.localhost = append(hp.localhost, lh...)
 
 	ll, err := hp.listen()
@@ -466,6 +470,8 @@ func (hp *HTTPProxy) directLocalhost(fn ProxyFunc) ProxyFunc {
 }
 
 func (hp *HTTPProxy) isLocalhost(host string) bool {
+	host = strings.ToLower(host)
+
 	if slices.Contains(hp.localhost, host) {
 		return true
 	}

diff --git a/http_proxy_test.go b/http_proxy_test.go
@@ -126,6 +126,7 @@ func TestIsLocalhost(t *testing.T) {
 		{"127.0.0.1", true},
 		{"127.10.20.30", true},
 		{"localhost", true},
+		{"LOCALHOST", true},
 		{"0.0.0.0", true},
 
 		{"notlocalhost", false},