Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrackedConn: optionally implement WriteTo() and ReadFrom() if the underlying connections supports it #842

Closed
mmatczuk opened this issue Jun 11, 2024 · 1 comment
Assignees
Milestone

Comments

@mmatczuk
Copy link
Contributor

The io.Copy has a built in optimization that can issue splice syscall to copy between file descriptors.
On a high level it boils down to checking if WriteTo() and ReadFrom() are implemented, see here.

We could use the same technique we use in delegator to provide type with implementations.
This should be also applied to CloseWrite().

@mmatczuk mmatczuk added this to the v1.4 milestone Jun 11, 2024
@mmatczuk mmatczuk self-assigned this Sep 3, 2024
@mmatczuk
Copy link
Contributor Author

mmatczuk commented Nov 5, 2024

Implemented in #943

@mmatczuk mmatczuk closed this as completed Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant