chore(utils/httpbin): make delay return 200 on contex cancel explicit #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmatczuk
force-pushed
the
mmt/nicer_delay
branch
from
3f937d4
to
1dea86c
Compare
Choraden
reviewed
Jul 25, 2024
| @@ -69,8 +69,9 @@ func delayHandler(w http.ResponseWriter, r *http.Request) { | |||
| case <-r.Context().Done(): | |||
| t.Stop() | |||
There was a problem hiding this comment.
Since we are here, shouldn't we also defer the timer stop?
There was a problem hiding this comment.
Don't mention it. It's a timer, not ticker.
There was a problem hiding this comment.
Sure, I'll add it.
Choraden
approved these changes
Jul 25, 2024
mmatczuk
force-pushed
the
mmt/nicer_delay
branch
from
1dea86c
to
c1f62fd
Compare
|
Improved commit messages, added deferred timer Stop() call. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.