Fix connect response that prevented proper working of websockets in FireFox #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using http.Response.Write() the resulting payload contains additional Connection: close header. Firefox treats that proxy response as server response preventing proper working of a connect tunnel. Fixes #938
…sponses Add writeConnectOKResponse() and modify proxyConn.writeResponse() to use it.
mmatczuk
changed the title
Choraden
reviewed
Nov 12, 2024
Comment on lines
-244
to
-247
| if res.ContentLength != -1 { | ||
| log.Errorf(ctx, "CONNECT response with Content-Length: %d, ignoring content length", res.ContentLength) | ||
| res.ContentLength = -1 | ||
| } |
There was a problem hiding this comment.
I wouldn't remove that. Even though, the proxy will now use raw bytes for connectOKResponse, It does not hurt us to keep this condition. That could print a useful log we are doing something wrong in some other place.
Choraden
reviewed
Nov 12, 2024
Comment on lines
+174
to
+179
| pc := proxyConn{ | ||
| Proxy: p.Proxy, | ||
| brw: brw, | ||
| conn: conn, | ||
| } | ||
| pc.writeResponse(res) |
There was a problem hiding this comment.
Fine, but it starts to look odd. Maybe there is some better way to share that code then 🤔.
There was a problem hiding this comment.
It looks ok to me tbh
Choraden
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #938