Do not close client connection after returning HTTP status code 304 #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
budziam
reviewed
Nov 21, 2024
Choraden
reviewed
Nov 21, 2024
Choraden
reviewed
Nov 21, 2024
internal/martian/proxy_test.go
Outdated
| if got, want := res.StatusCode, 304; got != want { | ||
| t.Fatalf("res.StatusCode: got %d, want %d", got, want) | ||
| } | ||
| if _, err := conn.Read(make([]byte, 0)); err != nil { |
There was a problem hiding this comment.
Let's read at least a byte.
There was a problem hiding this comment.
There is no byte, it would block, changing to nil.
Note that res.Body == http.NoBody is not always the case ex. when it's wrapped, or comes from http/2.
mmatczuk
force-pushed
the
mmt/304_hardening
branch
from
e6a8a65
to
5f6dce6
Compare
mmatczuk
force-pushed
the
mmt/304_hardening
branch
from
5f6dce6
to
5e5d2c4
Compare
Test ensures that after responding with status code 304 the connection is left intact.
mmatczuk
force-pushed
the
mmt/304_hardening
branch
from
5e5d2c4
to
67063b4
Compare
|
Fixed implementations renamed some functions |
budziam
approved these changes
Nov 21, 2024
…n extraction The std http package returns the underlying connection in body of 101 response. The response body needs to be removed form the response. Make reads from the replaced body panic to ensure that it's always handled correctly.
Choraden
reviewed
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.