Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish migration to 2.0 #23

Merged
merged 19 commits into from
Dec 18, 2023
Merged

Finish migration to 2.0 #23

merged 19 commits into from
Dec 18, 2023

Conversation

nulls
Copy link
Member

@nulls nulls commented Dec 15, 2023

What's done:

  • removed extra parameters
  • removed documentation for cli
  • fixed link to docs about cli
  • fixed version in docs

@nulls
Finish migration to 2.0
ae51fa8 
### What's done:
- removed extra parameters
- removed documentation for cli
- fixed link to docs about cli
- fixed version in docs
@kgevorkyan
Copy link
Member

not really understand why we remove all this information?

@nulls
Copy link
Member Author

nulls commented Dec 15, 2023

not really understand why we remove all this information?

removed extra parameters: relative-paths is not needed for diktat-cli. color I think is not needed in CI (but still works in diktat-cli). Also I left only two reporters: sarif or checkstyle. Only them can be uploaded to PR with found errors which is valuable.
Also diktat-cli now prints found errors to stdout by default and even when an another reporter to a file configured

removed documentation for cli: moved to diktat

@nulls nulls marked this pull request as ready for review December 18, 2023 10:51
@nulls nulls self-assigned this Dec 18, 2023
@nulls nulls merged commit b80b0a3 into master Dec 18, 2023
4 checks passed
@nulls nulls deleted the feature/remove-extra-parameters branch December 18, 2023 11:04
@nulls nulls mentioned this pull request Dec 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x6675636b796f75676974687562 0x6675636b796f75676974687562 0x6675636b796f75676974687562 approved these changes

Assignees

@nulls nulls

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nulls @kgevorkyan @0x6675636b796f75676974687562