review notes

saveourtool · Sep 26, 2023 · d955137 · d955137
1 parent e8ac545
commit d955137
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/info/available-rules.md b/info/available-rules.md
@@ -100,7 +100,7 @@
 | 4    | 4.2.2    | TYPE_ALIAS                                | Check: if the type reference of a property is longer than expected.                                                                                                                                                                                                 | yes | typeReferenceLength                                                                                                                                                                                                        | -                                                                                                                                                                                                                             |                                                                                                                                                                                                                        |
 | 4    | 4.3.1    | NULLABLE_PROPERTY_TYPE                    | Check: warns if an immutable property is initialized with null, or if the immutable property can have non-nullable type instead of nullable.<br>Fix: suggests the initial value instead of null or changes in the immutable property type.                                        | yes | no                                                                                                                                                                                                                         | -                                                                                                                                                                                                                             |
 | 4    | 4.3.2    | GENERIC_VARIABLE_WRONG_DECLARATION        | Check: warns if variables of generic types don't have an explicit type declaration.<br>Fix: fixes only the variables that have a generic declaration on both sides.                                                                                                     | yes | no                                                                                                                                                                                                                         | +                                                                                                                                                                                                                             |
-| 4    | 4.3.3    | AVOID_NULL_CHECKS                         | Check: warns if the null-check is used explicitly (for example: if (a == null)).                                                                                                                                                                                  | yes | no                                                                                                                                                                                                                         | Currently, no autofix.                                                                                                                                                                                                         |
+| 4    | 4.3.3    | AVOID_NULL_CHECKS                         | Check: warns if the null-check is used explicitly (for example: if (a == null)).                                                                                                                                                                                  | yes | no                                                                                                                                                                                                                         | Fix if\else conditions on null.                                                                                                                                                                                                         |
 | 5    | 5.1.1    | TOO_LONG_FUNCTION                         | Check: warns if the length of a function is too long.                                                                                                                                                                                                                     | no  | maxFunctionLength isIncludeHeader                                                                                                                                                                                          |                                                                                                                                                                                                                               |
 | 5    | 5.1.2    | NESTED_BLOCK                              | Warns if a function has more nested blocks than expected.                                                                                                                                                                                                       | no  | maxNestedBlockQuantit                                                                                                                                                                                                      |                                                                                                                                                                                                                               |
 | 5    | 5.1.3    | AVOID_NESTED_FUNCTIONS                    | Check: Warns if there are nested functions.<br>Fix: declare the function in the outer scope.                                                                                                                                                                         | yes | no                                                                                                                                                                                                                         | +                                                                                                                                                                                                                             |

diff --git a/info/rules-mapping.md b/info/rules-mapping.md
@@ -98,7 +98,7 @@
 | TYPE_ALIAS | [4.2.2](guide/diktat-coding-convention.md#r4.2.2) | no | Variables |
 | NULLABLE_PROPERTY_TYPE | [4.3.1](guide/diktat-coding-convention.md#r4.3.1) | yes | Variables |
 | GENERIC_VARIABLE_WRONG_DECLARATION | [4.3.2](guide/diktat-coding-convention.md#r4.3.2) | yes | Variables |
-| AVOID_NULL_CHECKS | [4.3.3](guide/diktat-coding-convention.md#r4.3.3) | no | Variables |
+| AVOID_NULL_CHECKS | [4.3.3](guide/diktat-coding-convention.md#r4.3.3) | yes | Variables |
 | TOO_LONG_FUNCTION | [5.1.1](guide/diktat-coding-convention.md#r5.1.1) | no | Functions |
 | NESTED_BLOCK | [5.1.2](guide/diktat-coding-convention.md#r5.1.2) | no | Functions |
 | AVOID_NESTED_FUNCTIONS | [5.1.3](guide/diktat-coding-convention.md#r5.1.3) | yes | Functions |