Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] Wrap Ktlint #1561

Closed
8 tasks done
nulls opened this issue Nov 15, 2022 · 4 comments
Closed
8 tasks done

[EPIC] Wrap Ktlint #1561

nulls opened this issue Nov 15, 2022 · 4 comments
Assignees
Labels
epic Major feature, could be decomposed into smaller tasks refactoring
Milestone

Comments

@nulls
Copy link
Member

nulls commented Nov 15, 2022

Right now diktat is run by calling ktlint which calls diktat.
Upgrade of diktat in spotless requires upgrade of ktlint.

Need to add a wrapper for running of ktlint in diktat

@nulls nulls self-assigned this Nov 15, 2022
nulls added a commit that referenced this issue Nov 15, 2022
### What's done:
- added a builder to run Diktat
- reused it in maven plugin

It's part of #1561
@nulls nulls changed the title Wrap Ktlint running [EPIC] Wrap Ktlint Nov 15, 2022
@nulls nulls added epic Major feature, could be decomposed into smaller tasks refactoring labels Nov 15, 2022
@nulls nulls added this to the ktlint-wrapper milestone Nov 15, 2022
@TWiStErRob
Copy link

Note: https://github.com/twitter/compose-rules/ project somehow managed to enable both Detekt and ktlint integration. I think you might be able to pull off the same with Spotless and ktlint (and maybe Detekt too, if you do, please add to https://detekt.dev/marketplace)

@TWiStErRob
Copy link

Off-topic tip: if you move the task list to the opening post, you'll get backlinks like this in children's header:
image

@nulls
Copy link
Member Author

nulls commented Nov 22, 2022

Off-topic tip: if you move the task list to the opening post, you'll get backlinks like this in children's header: image

cool, thanks

@nulls
Copy link
Member Author

nulls commented Nov 22, 2022

Note: https://github.com/twitter/compose-rules/ project somehow managed to enable both Detekt and ktlint integration. I think you might be able to pull off the same with Spotless and ktlint (and maybe Detekt too, if you do, please add to https://detekt.dev/marketplace)

Thanks, will look into it

@nulls nulls mentioned this issue Jan 9, 2023
1 task
@nulls nulls pinned this issue Mar 30, 2023
@nulls nulls modified the milestones: ktlint-wrapper, 2.0.0 Apr 7, 2023
@nulls nulls closed this as completed Nov 22, 2023
@nulls nulls unpinned this issue Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic Major feature, could be decomposed into smaller tasks refactoring
Projects
None yet
Development

No branches or pull requests

2 participants