Diktat API #1655
Merged
Diktat API #1655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: - added diktat-api - added diktat-ktlint-engine
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
diktat-api/src/main/kotlin/org/cqfn/diktat/api/DiktatProcessorListener.kt
Fixed
Show fixed
Hide fixed
Codecov Report
@@ Coverage Diff @@
## master #1655 +/- ##
============================================
- Coverage 80.74% 80.45% -0.29%
+ Complexity 2330 2320 -10
============================================
Files 117 121 +4
Lines 7909 7920 +11
Branches 2043 2036 -7
============================================
- Hits 6386 6372 -14
- Misses 621 649 +28
+ Partials 902 899 -3
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2) 161 files ±0 161 suites ±0 5m 50s ⏱️ ±0s Results for commit 741bf6a. ± Comparison against base commit 08836e7. ♻️ This comment has been updated with latest results. |
JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2) 161 files ±0 161 suites ±0 7m 56s ⏱️ -51s Results for commit 741bf6a. ± Comparison against base commit 08836e7. ♻️ This comment has been updated with latest results. |
diktat-gradle-plugin/src/main/kotlin/org/cqfn/diktat/plugin/gradle/tasks/DiktatTaskBase.kt
Fixed
Show fixed
Hide fixed
diktat-gradle-plugin/src/main/kotlin/org/cqfn/diktat/plugin/gradle/tasks/DiktatTaskBase.kt
Fixed
Show fixed
Hide fixed
nulls
requested review from
icemachined,
sanyavertolet,
Cheshiriks,
orchestr7 and
0x6675636b796f75676974687562
Cheshiriks
approved these changes
Apr 5, 2023
Merged
nulls
added a commit
that referenced
this pull request
Nov 23, 2023
- fixed checking configFile - restored logic for input and exclude in maven plugin (removed in #1655) - fixed warning about provided dependency in maven plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
diktat-api-- it contains all API interfaces which need to rundiktatdiktat-ktlint-engine-- it contains implementations fordiktat-apiktlint-coreadded todiktat-rulesto useElementTypes. There is a branch to fix all imports, but it contains a lot of changes... master...feature/ktlint-importsDiktatRunner*to use a common approach to rundiktaton a bunch of files: it creates baseline, reporter and applying a formatted code to fileCherry-picked #1566