Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version wrong in 0.5.14 release? #608

Open
fryfrog opened this issue Dec 23, 2024 · 3 comments
Open

Version wrong in 0.5.14 release? #608

fryfrog opened this issue Dec 23, 2024 · 3 comments

Comments

@fryfrog
Copy link

fryfrog commented Dec 23, 2024

Expected Behaviour

I was digging around in an issue w/ the AUR python-num2words package and noticed that something is still resulting in a num2words-0.5.13.dist-info folder name. I switch to the tag here on github and see that the bin/num2words binary still says 0.5.13, but I'm not sure if that explains it entirely. I'm not very good at the python building, so I'm not quite sure where else to look.

fryfrog@apollo …/lib/python3.13/site-packages  on  master [!] ❯ pwd
/home/fryfrog/aur/python-num2words/pkg/python-num2words/usr/lib/python3.13/site-packages
fryfrog@apollo …/lib/python3.13/site-packages  on  master [!] ❯ ls
num2words  num2words-0.5.13.dist-info
fryfrog@apollo …/python-num2words/src/num2words-0.5.14  on  master [!] via 🐍 v3.13.1 ❯ grep -ir "0.5.13" .
./build/scripts-3.13/num2words:__version__ = "0.5.13"
./bin/num2words:__version__ = "0.5.13"
./num2words.egg-info/PKG-INFO:Version: 0.5.13
./num2words.egg-info/PKG-INFO:Version 0.5.13 -- 2023/10/18
./CHANGES.rst:Version 0.5.13 -- 2023/10/18
grep: ./dist/num2words-0.5.13-py3-none-any.whl: binary file matches

Actual Behaviour

We should see 0.5.14! :)

Steps to reproduce

Extract your v0.5.14.tar.gz and do...

fryfrog@apollo ~/temp/num2words-0.5.14  via 🐍 v3.13.1 ❯ grep -ir "0.5.13" .
./bin/num2words:__version__ = "0.5.13"
./CHANGES.rst:Version 0.5.13 -- 2023/10/18
@Rogach
Copy link

Rogach commented Dec 24, 2024

That's because tag v0.5.14 was placed on a commit one before the release commit (6abe2c6 instead of 2b4d0bb). And in that commit bin/num2words still contains __version__ = "0.5.13".

@fryfrog
Copy link
Author

fryfrog commented Dec 24, 2024

Does that explain the num2words-0.5.13.dist-info folder name too?

@Rogach
Copy link

Rogach commented Dec 24, 2024

Yes, changing the __version__ line changes the folder name as well (I do not know much about Python packging, but I guess something looks at that __version__ during the build process).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants