Feature/clang tidy #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
nyxrobotics
force-pushed
the
feature/clang-tidy
branch
from
d57dd8e
to
e371b4e
Compare
nyxrobotics
force-pushed
the
feature/clang-tidy
branch
from
e371b4e
to
16811fd
Compare
nyxrobotics
force-pushed
the
feature/clang-tidy
branch
from
16811fd
to
85e8449
Compare
This comment was marked as resolved.
This comment was marked as resolved.
nyxrobotics
force-pushed
the
feature/clang-tidy
branch
2 times, most recently
from
34b2db3
to
5d14708
Compare
|
リポジトリでキーの設定せずにciの設定だけコピーしたのでsshでコケていました |
|
@nyxrobotics |
|
とりあえず作業完了です |
jsupratman13
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Detail
つくばチャレンジの出場に伴って行った変更が多く、あとから見やすいようフォーマット・ファイル分割を掛けてから変更作業に移ろうと思っています
本来は本家のコーディングルールを使いたいのですがclang-formatの設定しかなく、clang-formatだけ元の書式にしてもあまり意味はないかなと思い全てsbgisenの設定にしました
forkしたリポジトリなのでciの設定はどうすべきか微妙だったのでgithubのチェックは走っていません
Impact
Test
Attention