[1.x] Use inclusive language on internal terminology #1505
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Friendseeker
commented
Nov 25, 2024
|
|
||
| private[this] def scalaLib(scalaHome: File): File = | ||
| new File(scalaHome, "lib") | ||
|
|
||
| private[this] val blacklist: Set[String] = Set( | ||
| private[this] val excludeList: Set[String] = Set( |
There was a problem hiding this comment.
Btw I actually don't understand what does the excludeList do, but I guess there's probably a better way compared to special casing a bunch of jars...
If someone can decipher what's going on, might be able to remove excludeList altogether.
There was a problem hiding this comment.
Likely this code is related to sbt and Zinc's use of layered classloader, where we construct ClassLoader instance using Scala distribution of a specific version (scala-library.jar etc) for performance. In this case, we're trying to exclude non-essential JARs that were historically distributed and/or placed in scalaHome (for scala compiler developers this could be someone on disk)?
eed3si9n
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c.c. scala/scala3#21988