Skip to content

Commit 1cb32cc

Browse files
sbuliarcasbuliarca
committed
Added more metrics to be reported
1 parent 46a6744 commit 1cb32cc

File tree

3 files changed

+73
-62
lines changed

3 files changed

+73
-62
lines changed

‎examples/bench/bench-fetch-max-partition-bytes/client_benchmark_test.go

+11
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ func BenchmarkPollRecords(b *testing.B) {
5151
kgo.BlockRebalanceOnPoll(),
5252
// use 10MB
5353
//kgo.FetchMaxPartitionBytes(10*1024*1024),
54+
kgo.WithHooks(&recordBatchReadHook{b: b}),
5455
)
5556

5657
require.NoError(b, err)
@@ -68,6 +69,16 @@ func BenchmarkPollRecords(b *testing.B) {
6869
}
6970
}
7071

72+
type recordBatchReadHook struct {
73+
b *testing.B
74+
}
75+
76+
func (h *recordBatchReadHook) OnFetchBatchRead(meta kgo.BrokerMetadata, topic string, partition int32, metrics kgo.FetchBatchMetrics) {
77+
h.b.ReportMetric(float64(metrics.CompressedBytes/h.b.N), "compressedbytes/op")
78+
h.b.ReportMetric(float64(metrics.UncompressedBytes/h.b.N), "uncompressedbytes/op")
79+
h.b.ReportMetric(float64(metrics.NumRecords), "recs/op")
80+
}
81+
7182
func populateTopic(ctx context.Context, t *testing.B, broker string, topicName string) error {
7283
t.Log("Start topic population")
7384
producer, err := kgo.NewClient(

‎examples/bench/bench-fetch-max-partition-bytes/testrun_normal.txt

+31-31
Original file line numberDiff line numberDiff line change
@@ -1,50 +1,50 @@
11
goos: darwin
22
goarch: arm64
33
pkg: github.com/utilitywarehouse/franz-go/examples/bench/bench-fetch-max-partition-bytes
4-
BenchmarkPollRecords 1 3398178250 ns/op 132786712 B/op 13763 allocs/op
4+
BenchmarkPollRecords 1 3380654666 ns/op 59720 compressedbytes/op 97.00 recs/op 994865 uncompressedbytes/op 132888208 B/op 13815 allocs/op
55
--- BENCH: BenchmarkPollRecords
6-
client_benchmark_test.go:73: Start topic population
7-
BenchmarkPollRecords 1 3435248375 ns/op 132792696 B/op 13748 allocs/op
6+
client_benchmark_test.go:83: Start topic population
7+
BenchmarkPollRecords 1 3421492833 ns/op 59720 compressedbytes/op 97.00 recs/op 994865 uncompressedbytes/op 132877696 B/op 13798 allocs/op
88
--- BENCH: BenchmarkPollRecords
9-
client_benchmark_test.go:73: Start topic population
10-
BenchmarkPollRecords 1 3403719666 ns/op 132784440 B/op 13747 allocs/op
9+
client_benchmark_test.go:83: Start topic population
10+
BenchmarkPollRecords 1 3381904750 ns/op 59720 compressedbytes/op 97.00 recs/op 994865 uncompressedbytes/op 132877696 B/op 13798 allocs/op
1111
--- BENCH: BenchmarkPollRecords
12-
client_benchmark_test.go:73: Start topic population
13-
BenchmarkPollRecords 1 3412771375 ns/op 132784440 B/op 13747 allocs/op
12+
client_benchmark_test.go:83: Start topic population
13+
BenchmarkPollRecords 1 3498154791 ns/op 59720 compressedbytes/op 97.00 recs/op 994865 uncompressedbytes/op 132877696 B/op 13798 allocs/op
1414
--- BENCH: BenchmarkPollRecords
15-
client_benchmark_test.go:73: Start topic population
16-
BenchmarkPollRecords 1 3359152166 ns/op 132784440 B/op 13747 allocs/op
15+
client_benchmark_test.go:83: Start topic population
16+
BenchmarkPollRecords 1 3427531208 ns/op 59720 compressedbytes/op 97.00 recs/op 994865 uncompressedbytes/op 132877696 B/op 13798 allocs/op
1717
--- BENCH: BenchmarkPollRecords
18-
client_benchmark_test.go:73: Start topic population
19-
BenchmarkPollRecords 1 3325048167 ns/op 132784440 B/op 13747 allocs/op
18+
client_benchmark_test.go:83: Start topic population
19+
BenchmarkPollRecords 1 3383784291 ns/op 59720 compressedbytes/op 97.00 recs/op 994865 uncompressedbytes/op 132877760 B/op 13799 allocs/op
2020
--- BENCH: BenchmarkPollRecords
21-
client_benchmark_test.go:73: Start topic population
22-
BenchmarkPollRecords 1 3385772083 ns/op 132784440 B/op 13747 allocs/op
21+
client_benchmark_test.go:83: Start topic population
22+
BenchmarkPollRecords 1 3460221375 ns/op 59720 compressedbytes/op 97.00 recs/op 994865 uncompressedbytes/op 132877696 B/op 13798 allocs/op
2323
--- BENCH: BenchmarkPollRecords
24-
client_benchmark_test.go:73: Start topic population
25-
BenchmarkPollRecords 1 3395793292 ns/op 132792632 B/op 13747 allocs/op
24+
client_benchmark_test.go:83: Start topic population
25+
BenchmarkPollRecords 1 3356974916 ns/op 59720 compressedbytes/op 97.00 recs/op 994865 uncompressedbytes/op 132877744 B/op 13799 allocs/op
2626
--- BENCH: BenchmarkPollRecords
27-
client_benchmark_test.go:73: Start topic population
28-
BenchmarkPollRecords 1 3347914292 ns/op 132784440 B/op 13747 allocs/op
27+
client_benchmark_test.go:83: Start topic population
28+
BenchmarkPollRecords 1 3472819708 ns/op 59720 compressedbytes/op 97.00 recs/op 994865 uncompressedbytes/op 132877696 B/op 13798 allocs/op
2929
--- BENCH: BenchmarkPollRecords
30-
client_benchmark_test.go:73: Start topic population
31-
BenchmarkPollRecords 1 3444155708 ns/op 132784832 B/op 13749 allocs/op
30+
client_benchmark_test.go:83: Start topic population
31+
BenchmarkPollRecords 1 3478237125 ns/op 59720 compressedbytes/op 97.00 recs/op 994865 uncompressedbytes/op 132877744 B/op 13799 allocs/op
3232
--- BENCH: BenchmarkPollRecords
33-
client_benchmark_test.go:73: Start topic population
34-
BenchmarkPollRecords 1 3378210667 ns/op 132784440 B/op 13747 allocs/op
33+
client_benchmark_test.go:83: Start topic population
34+
BenchmarkPollRecords 1 3466253084 ns/op 59720 compressedbytes/op 97.00 recs/op 994865 uncompressedbytes/op 132877696 B/op 13798 allocs/op
3535
--- BENCH: BenchmarkPollRecords
36-
client_benchmark_test.go:73: Start topic population
37-
BenchmarkPollRecords 1 3361311416 ns/op 132784440 B/op 13747 allocs/op
36+
client_benchmark_test.go:83: Start topic population
37+
BenchmarkPollRecords 1 3332905542 ns/op 59720 compressedbytes/op 97.00 recs/op 994865 uncompressedbytes/op 132877696 B/op 13798 allocs/op
3838
--- BENCH: BenchmarkPollRecords
39-
client_benchmark_test.go:73: Start topic population
40-
BenchmarkPollRecords 1 3389551542 ns/op 132784440 B/op 13747 allocs/op
39+
client_benchmark_test.go:83: Start topic population
40+
BenchmarkPollRecords 1 3371719375 ns/op 59720 compressedbytes/op 97.00 recs/op 994865 uncompressedbytes/op 132877696 B/op 13798 allocs/op
4141
--- BENCH: BenchmarkPollRecords
42-
client_benchmark_test.go:73: Start topic population
43-
BenchmarkPollRecords 1 3451477334 ns/op 132784504 B/op 13748 allocs/op
42+
client_benchmark_test.go:83: Start topic population
43+
BenchmarkPollRecords 1 3406518625 ns/op 59720 compressedbytes/op 97.00 recs/op 994865 uncompressedbytes/op 132877696 B/op 13798 allocs/op
4444
--- BENCH: BenchmarkPollRecords
45-
client_benchmark_test.go:73: Start topic population
46-
BenchmarkPollRecords 1 3420341917 ns/op 132792632 B/op 13747 allocs/op
45+
client_benchmark_test.go:83: Start topic population
46+
BenchmarkPollRecords 1 3376844791 ns/op 59721 compressedbytes/op 97.00 recs/op 994865 uncompressedbytes/op 136133760 B/op 14098 allocs/op
4747
--- BENCH: BenchmarkPollRecords
48-
client_benchmark_test.go:73: Start topic population
48+
client_benchmark_test.go:83: Start topic population
4949
PASS
50-
ok github.com/utilitywarehouse/franz-go/examples/bench/bench-fetch-max-partition-bytes 141.652s
50+
ok github.com/utilitywarehouse/franz-go/examples/bench/bench-fetch-max-partition-bytes 141.396s

‎examples/bench/bench-fetch-max-partition-bytes/testrun_with_FetchMaxPartitionBytes10MB.txt

+31-31
Original file line numberDiff line numberDiff line change
@@ -1,50 +1,50 @@
11
goos: darwin
22
goarch: arm64
33
pkg: github.com/utilitywarehouse/franz-go/examples/bench/bench-fetch-max-partition-bytes
4-
BenchmarkPollRecords 1 3829666416 ns/op 655719896 B/op 61927 allocs/op
4+
BenchmarkPollRecords 1 3703996084 ns/op 59720 compressedbytes/op 97.00 recs/op 994865 uncompressedbytes/op 655723216 B/op 61981 allocs/op
55
--- BENCH: BenchmarkPollRecords
6-
client_benchmark_test.go:72: Start topic population
7-
BenchmarkPollRecords 1 3738498583 ns/op 655709560 B/op 61912 allocs/op
6+
client_benchmark_test.go:83: Start topic population
7+
BenchmarkPollRecords 1 3600582375 ns/op 59720 compressedbytes/op 97.00 recs/op 994865 uncompressedbytes/op 655721024 B/op 61965 allocs/op
88
--- BENCH: BenchmarkPollRecords
9-
client_benchmark_test.go:72: Start topic population
10-
BenchmarkPollRecords 1 3645801375 ns/op 655717752 B/op 61912 allocs/op
9+
client_benchmark_test.go:83: Start topic population
10+
BenchmarkPollRecords 1 3705450875 ns/op 59721 compressedbytes/op 97.00 recs/op 994865 uncompressedbytes/op 655712832 B/op 61965 allocs/op
1111
--- BENCH: BenchmarkPollRecords
12-
client_benchmark_test.go:72: Start topic population
13-
BenchmarkPollRecords 1 3726165833 ns/op 655717752 B/op 61912 allocs/op
12+
client_benchmark_test.go:83: Start topic population
13+
BenchmarkPollRecords 1 3627957166 ns/op 59720 compressedbytes/op 97.00 recs/op 994865 uncompressedbytes/op 655721024 B/op 61965 allocs/op
1414
--- BENCH: BenchmarkPollRecords
15-
client_benchmark_test.go:72: Start topic population
16-
BenchmarkPollRecords 1 3678846000 ns/op 655717752 B/op 61912 allocs/op
15+
client_benchmark_test.go:83: Start topic population
16+
BenchmarkPollRecords 1 3666480541 ns/op 59721 compressedbytes/op 97.00 recs/op 994865 uncompressedbytes/op 655721024 B/op 61965 allocs/op
1717
--- BENCH: BenchmarkPollRecords
18-
client_benchmark_test.go:72: Start topic population
19-
BenchmarkPollRecords 1 3667193375 ns/op 655717760 B/op 61913 allocs/op
18+
client_benchmark_test.go:83: Start topic population
19+
BenchmarkPollRecords 1 3702227417 ns/op 59720 compressedbytes/op 97.00 recs/op 994865 uncompressedbytes/op 655721024 B/op 61965 allocs/op
2020
--- BENCH: BenchmarkPollRecords
21-
client_benchmark_test.go:72: Start topic population
22-
BenchmarkPollRecords 1 3730089834 ns/op 655717752 B/op 61912 allocs/op
21+
client_benchmark_test.go:83: Start topic population
22+
BenchmarkPollRecords 1 3677487208 ns/op 59720 compressedbytes/op 97.00 recs/op 994865 uncompressedbytes/op 655721032 B/op 61966 allocs/op
2323
--- BENCH: BenchmarkPollRecords
24-
client_benchmark_test.go:72: Start topic population
25-
BenchmarkPollRecords 1 3658629292 ns/op 655717760 B/op 61913 allocs/op
24+
client_benchmark_test.go:83: Start topic population
25+
BenchmarkPollRecords 1 3608964833 ns/op 59720 compressedbytes/op 97.00 recs/op 994865 uncompressedbytes/op 655721120 B/op 61967 allocs/op
2626
--- BENCH: BenchmarkPollRecords
27-
client_benchmark_test.go:72: Start topic population
28-
BenchmarkPollRecords 1 3697711792 ns/op 655717752 B/op 61912 allocs/op
27+
client_benchmark_test.go:83: Start topic population
28+
BenchmarkPollRecords 1 3761873958 ns/op 59720 compressedbytes/op 97.00 recs/op 994865 uncompressedbytes/op 655712832 B/op 61965 allocs/op
2929
--- BENCH: BenchmarkPollRecords
30-
client_benchmark_test.go:72: Start topic population
31-
BenchmarkPollRecords 1 4036467625 ns/op 655725088 B/op 62040 allocs/op
30+
client_benchmark_test.go:83: Start topic population
31+
BenchmarkPollRecords 1 3654043250 ns/op 59720 compressedbytes/op 97.00 recs/op 994865 uncompressedbytes/op 655721024 B/op 61965 allocs/op
3232
--- BENCH: BenchmarkPollRecords
33-
client_benchmark_test.go:72: Start topic population
34-
BenchmarkPollRecords 1 3633774709 ns/op 655717944 B/op 61915 allocs/op
33+
client_benchmark_test.go:83: Start topic population
34+
BenchmarkPollRecords 1 3651506333 ns/op 59720 compressedbytes/op 97.00 recs/op 994865 uncompressedbytes/op 655721032 B/op 61966 allocs/op
3535
--- BENCH: BenchmarkPollRecords
36-
client_benchmark_test.go:72: Start topic population
37-
BenchmarkPollRecords 1 3737647833 ns/op 655717752 B/op 61912 allocs/op
36+
client_benchmark_test.go:83: Start topic population
37+
BenchmarkPollRecords 1 3652002958 ns/op 59720 compressedbytes/op 97.00 recs/op 994865 uncompressedbytes/op 655721024 B/op 61965 allocs/op
3838
--- BENCH: BenchmarkPollRecords
39-
client_benchmark_test.go:72: Start topic population
40-
BenchmarkPollRecords 1 3755905375 ns/op 655717824 B/op 61914 allocs/op
39+
client_benchmark_test.go:83: Start topic population
40+
BenchmarkPollRecords 1 3609690000 ns/op 59720 compressedbytes/op 97.00 recs/op 994865 uncompressedbytes/op 655721464 B/op 61969 allocs/op
4141
--- BENCH: BenchmarkPollRecords
42-
client_benchmark_test.go:72: Start topic population
43-
BenchmarkPollRecords 1 3632494417 ns/op 655717912 B/op 61914 allocs/op
42+
client_benchmark_test.go:83: Start topic population
43+
BenchmarkPollRecords 1 3685752542 ns/op 59720 compressedbytes/op 97.00 recs/op 994865 uncompressedbytes/op 655712832 B/op 61965 allocs/op
4444
--- BENCH: BenchmarkPollRecords
45-
client_benchmark_test.go:72: Start topic population
46-
BenchmarkPollRecords 1 3633394459 ns/op 655709560 B/op 61912 allocs/op
45+
client_benchmark_test.go:83: Start topic population
46+
BenchmarkPollRecords 1 3820594291 ns/op 59720 compressedbytes/op 97.00 recs/op 994865 uncompressedbytes/op 655721024 B/op 61965 allocs/op
4747
--- BENCH: BenchmarkPollRecords
48-
client_benchmark_test.go:72: Start topic population
48+
client_benchmark_test.go:83: Start topic population
4949
PASS
50-
ok github.com/utilitywarehouse/franz-go/examples/bench/bench-fetch-max-partition-bytes 150.416s
50+
ok github.com/utilitywarehouse/franz-go/examples/bench/bench-fetch-max-partition-bytes 140.556s

0 commit comments

Comments
 (0)