Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charge Overview is not secured #215

Open
arakla opened this issue May 6, 2016 · 7 comments
Open

Charge Overview is not secured #215

arakla opened this issue May 6, 2016 · 7 comments

Comments

@arakla
Copy link
Member

arakla commented May 6, 2016

The charge overview is not secured. It should be scc or admins only. Currently it works without a login. Additionally, it is not linked to from anywhere. That being said, this needs to be accessible to a few non-admin people (Advisors and Financial Admins). Do not make this fix live before 5/20/16, unless #216 is implemented.

@pkoenig10
Copy link
Member

I won't fix it before then. But can't we just give access to Binder users in the Student Activities org?

@arakla
Copy link
Member Author

arakla commented May 6, 2016

We can and I have, but to be able to see all the charges, they need to be added as a member of each org. And I wasn't sure if they needed to be booth chairs, so then I had to make them a booth chair of each org after adding them to the orgs.

Additionally, it would be much easier if this was seeded into the db or persisted year to year. Also, we don't actually want them to be listed as a participant or booth chair. Furthermore, not everyone is in DOSA/Student Activities, such as MCS' advisors/admins

@pkoenig10
Copy link
Member

We can give them the same permissions we currently give SCC members.

@arakla
Copy link
Member Author

arakla commented May 6, 2016

But an advisor or financial admin shouldn't be able to change the charges, edit orgs that they aren't responsible for, and so on.

@pkoenig10
Copy link
Member

Sure, we can make those adjustments accordingly.

@ChaseBro
Copy link
Member

ChaseBro commented May 6, 2016

Are we really worried that an advisor will go rogue? I think we should just
give them access and keep good logs (although it should be relatively
simple to grant them read but not edit rights).

On Thu, May 5, 2016 at 9:46 PM Patrick Koenig [email protected]
wrote:

Sure, we can make those adjustments accordingly.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#215 (comment)

@arakla
Copy link
Member Author

arakla commented May 6, 2016

I'm not really worried about them going rogue as much as how they appear on
binder, security in general (or at least trying to have some semblance of
it), people accidentally doing something.

On Friday, May 6, 2016, Chase Brownell [email protected] wrote:

Are we really worried that an advisor will go rogue? I think we should just
give them access and keep good logs (although it should be relatively
simple to grant them read but not edit rights).

On Thu, May 5, 2016 at 9:46 PM Patrick Koenig <[email protected]
javascript:_e(%7B%7D,'cvml','[email protected]');>
wrote:

Sure, we can make those adjustments accordingly.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#215 (comment)


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#215 (comment)

Aamer F. Rakla
B.H.A. Information Systems & Drama: Production and Stage Management
Carnegie Mellon University, 2016

Boss Ambassador (Mentor), Student Life Office
Financial Advisor, Student Dormitory Council
Treasurer, Spring Carnival Committee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants