Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retract previously opened Pull Request #3488

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Retract previously opened Pull Request #3488

wants to merge 1 commit into from

Conversation

mzuehlke
Copy link
Member

The updates.retraced section of the scala-steward.conf allows to declare updates that should be retracted. Each entry must have a reason, a doc URL and a list of dependency patterns.

Example:

updates.retracted = [
  {
    reason = "Ignore version 3.6.0 as it is abandoned due to broken compatibility",
    doc = "https://contributors.scala-lang.org/t/broken-scala-3-6-0-release/6792",
    artifacts = [
      { groupId = "org.scala-lang", artifactId = "scala3-compiler", version = { exact = "3.6.0" } }
    ]
  }
]

Retraction of Pull Request is only possible, if the workspace is persisted correctly. (https://github.com/scala-steward-org/scala-steward/blob/main/docs/faq.md#why-doesnt-self-hosted-scala-steward-close-obsolete-prs)

Fixes: #3445

The `updates.retraced` section of the `scala-steward.conf` allows to declare updates that should be retracted. Each entry must have a `reason, a `doc` URL and a list of dependency patterns.

Example:
```
updates.retracted = [
  {
    reason = "Ignore version 3.6.0 as it is abandoned due to broken compatibility",
    doc = "https://contributors.scala-lang.org/t/broken-scala-3-6-0-release/6792",
    artifacts = [
      { groupId = "org.scala-lang", artifactId = "scala3-compiler", version = { exact = "3.6.0" } }
    ]
  }
]
```
Retraction of Pull Request is only possible, if the workspace is persisted correctly. (https://github.com/scala-steward-org/scala-steward/blob/main/docs/faq.md#why-doesnt-self-hosted-scala-steward-close-obsolete-prs)

Fixes: #3445
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 20 lines in your changes missing coverage. Please review.

Project coverage is 89.67%. Comparing base (916c6a1) to head (e6131eb).

Files with missing lines Patch % Lines
...ala/org/scalasteward/core/nurture/NurtureAlg.scala 0.00% 12 Missing ⚠️
...org/scalasteward/core/application/StewardAlg.scala 0.00% 6 Missing ⚠️
...lasteward/core/nurture/PullRequestRepository.scala 87.50% 1 Missing ⚠️
...alasteward/core/repoconfig/RetractedArtifact.scala 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3488      +/-   ##
==========================================
- Coverage   90.07%   89.67%   -0.41%     
==========================================
  Files         170      171       +1     
  Lines        3497     3526      +29     
  Branches      320      357      +37     
==========================================
+ Hits         3150     3162      +12     
- Misses        347      364      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mzuehlke mzuehlke requested review from fthomas, alejandrohdezma and exoego and removed request for fthomas November 29, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Closing pull-requests for retracted versions
1 participant