Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Basic Auth for GitHub again #3481

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Support Basic Auth for GitHub again #3481

merged 1 commit into from
Nov 21, 2024

Conversation

joan38
Copy link
Contributor

@joan38 joan38 commented Nov 20, 2024 •
edited
Loading

@joan38 joan38 mentioned this pull request Nov 20, 2024
Closed
@joan38
Copy link
Contributor Author

joan38 commented Nov 20, 2024

Not sure what's the issue with the build

@mzuehlke
Copy link
Member

scalameta/scalafmt#4571 is the issue

@joan38
Copy link
Contributor Author

joan38 commented Nov 20, 2024

Sounds like we are blocked?

@joan38 joan38 mentioned this pull request Nov 20, 2024
Closed
@mzuehlke
Copy link
Member

mzuehlke commented Nov 20, 2024 •
edited
Loading

Maybe we could unblock it if we request a specific version of scalafmt.
Add ":3.8.3" here https://github.com/scala-steward-org/scala-steward/blob/main/build.sbt#L58
and regenerate the github actions using sbt githubWorkflowGenerate

See: https://get-coursier.io/docs/cli-install

@joan38
Copy link
Contributor Author

joan38 commented Nov 20, 2024 •
edited
Loading

@mzuehlke all good now. Thanks!

mzuehlke
mzuehlke approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@mzuehlke mzuehlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reacting that fast 👍

@mzuehlke mzuehlke added the bug Something isn't working label Nov 21, 2024
@mzuehlke mzuehlke merged commit f289203 into scala-steward-org:main Nov 21, 2024
5 checks passed
@mzuehlke mzuehlke added this to the 0.31.2 milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzuehlke mzuehlke mzuehlke approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.32.0
Development

Successfully merging this pull request may close these issues.
2 participants
@joan38 @mzuehlke