-Yexplicit-nulls does not play nicely with Option.apply

[j-mie6]

Compiler version

3.5.2

Minimized example

//> using options -Yexplicit-nulls

class Foo
Option[Foo](null)

Output

Gives a type error that expected Foo but got Null. Fine, except the point of Option.apply is that it is a null-safe wrapper into Option.

Expectation

Realistically, its type needs to be def apply[A](x: A | Null): Option[A] when that flag is turned on, otherwise it's now useless.

[Gedochao]

cc @noti0na1

[noti0na1]

Since we couldn't update the std library right now, there is a "patch" function for Option defined at library/src/scala/runtime/stdLibPatches/Predef.scala

  extension (opt: Option.type)
    @experimental
    inline def fromNullable[T](t: T | Null): Option[T] = Option(t).asInstanceOf[Option[T]]

[Gedochao]

@noti0na1 potentially could be improved after #22043