Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated methods from implicit conversions in completions #22624

Open
tgodzik opened this issue Feb 18, 2025 · 1 comment
Open

Duplicated methods from implicit conversions in completions #22624

tgodzik opened this issue Feb 18, 2025 · 1 comment
Labels
area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools itype:bug

Comments

@tgodzik
Copy link
Contributor

tgodzik commented Feb 18, 2025

Compiler version

3.6.3

Minimized code

Array(1,2,3).fil@@

Output

Multiple filter methods with the same signature.

Expectation

Single filter and filterNot method

First tackled in #14036

@tgodzik tgodzik added area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools itype:bug stat:needs triage Every issue needs to have an "area" and "itype" label labels Feb 18, 2025
@rochala
Copy link
Contributor

rochala commented Feb 19, 2025

I tried fixing this issue some time ago.
As far as I remember, my approach was to adjust implicit search to not search all implicits:
val conversions = new typer.ImplicitSearch(defn.AnyType, qual, pos.span).allImplicits

But rather, actually find the best implicit:
1.isFini one coming from RichInt and the latter from RichLong
I did not not have much of success though

@Gedochao Gedochao removed the stat:needs triage Every issue needs to have an "area" and "itype" label label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools itype:bug
Projects
None yet
Development

No branches or pull requests

3 participants