Do not crash when typing a closure with unknown type, since it can occur for erroneous input #21178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cur for erroneous input
KacperFKorban
force-pushed
the
fix-i20511
branch
from
6299833 to
ec5cbcc
Compare
hamzaremmal
requested changes
Sep 20, 2024
Comment on lines
-1980
to
-1981
| if !tp.isErroneous then | ||
| throw new java.lang.Error(i"internal error: closing over non-method $tp, pos = ${tree.span}") |
There was a problem hiding this comment.
I don't think this is the correct fix. IMHO, for this kind of errors, we shouldn't run the typer in the first place.
There was a problem hiding this comment.
Hmmm, I think that this might actually be the correct fix. I even tried short-circuiting before typing ahead in Namer, but the presentation compiler leverages this for completions.
There was a problem hiding this comment.
Alright, but we should open an issue for a better error messages !
hamzaremmal
approved these changes
Nov 19, 2024
Comment on lines
-1980
to
-1981
| if !tp.isErroneous then | ||
| throw new java.lang.Error(i"internal error: closing over non-method $tp, pos = ${tree.span}") |
There was a problem hiding this comment.
Alright, but we should open an issue for a better error messages !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #20511