Ensure to escape characters before constructing JSON profile trace #21872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WojciechMazur
force-pushed
the
fix/21858
branch
from
8dc420e to
2f61ee2
Compare
prolativ
approved these changes
Nov 8, 2024
| // Based on NameTransformer but dedicated for JSON encoding rules | ||
| object JsonNameTransformer { | ||
| private val nops = 128 | ||
| private val ncodes = 26 * 26 |
prolativ
approved these changes
Nov 8, 2024
mbovel
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
It seems a bit crazy to me that we need to rewrite a JSON escape function in 2024, but I guess this goes with the "no-dependency" policy of Dotty, and the fact that neither the Java nor the Scala standard libraries contain such function.
Otherwise looks okay to me!
compiler/src/dotty/tools/dotc/profile/JsonNameTransformer.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Matt Bovel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21858 by setting up special escapes for characters that might corrupt the output JSON file produced by
-Yprofile-trace