Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REPL: JLine: follow recommendation to use JNI, not JNA; also JLine 3.27.1 (was 3.27.0) #22205

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Dec 13, 2024

as per the https://github.com/jline/jline3 readme

and as per discussion and linked items on #22201

fixes #22201

note that as far as I can tell, the stuff I removed from libexec/common-shared is dead code

@philwalk dunno if you're still around but judging from #12405 you might be a good reviewer here

note that I believe we don't need to also port scala/scala#10889 here, since we are already using separate JLine JARs rather than the all-in-one JAR

I've chosen not to upgrade all the way to JLine 3.28.0 at the moment, as it is quite new (2 days ago) and doesn't appear to have any fixes that might be critical.

@SethTisue
Copy link
Member Author

SethTisue commented Dec 13, 2024

I am not a good person to test this on Windows, as I don't currently even have a working Windows setup... and even if I did, I know nothing about cygwin/conemu/mingw/???, it's just meaningless noises to me

I've added the "backport:nominated" label, but it probably shouldn't be backported to LTS too soon? Might be better to ship it in a 3.6.x release first and make sure the Windows users don't take up torches and pitchforks in response?

We are more or less YOLOing this in both sbt and Scala 2.13.16, so we might get problem reports from either of those, too. cc @Friendseeker

Regardless, I don't think we need to be too frightened, as JLine is in wide use outside of Scala as well.

@SethTisue SethTisue added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Dec 13, 2024
@SethTisue SethTisue changed the title REPL: JLine: follow recommendation to use JNI, not JNA REPL: JLine: follow recommendation to use JNI, not JNA; also JLine 3.27.1 (was 3.27.0) Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REPL warns terminal provider jna has been deprecated
1 participant